Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged

[Baolin Wang]

On 2024/10/15 10:02, Nanyong Sun wrote:

The mount option of tmpfs should be huge=advise, not madvise
which is not supported and may mislead the users.

Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing")
Signed-off-by: Nanyong Sun <sunnany...@huawei.com>

LGTM.
Reviewed-by: Baolin Wang <baolin.w...@linux.alibaba.com>

---
  tools/testing/selftests/mm/khugepaged.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/khugepaged.c 
b/tools/testing/selftests/mm/khugepaged.c
index 56d4480e8d3c..8a4d34cce36b 100644
--- a/tools/testing/selftests/mm/khugepaged.c
+++ b/tools/testing/selftests/mm/khugepaged.c
@@ -1091,7 +1091,7 @@ static void usage(void)
        fprintf(stderr, "\n\t\"file,all\" mem_type requires kernel built 
with\n");
        fprintf(stderr, "\tCONFIG_READ_ONLY_THP_FOR_FS=y\n");
        fprintf(stderr, "\n\tif [dir] is a (sub)directory of a tmpfs mount, tmpfs 
must be\n");
-       fprintf(stderr, "\tmounted with huge=madvise option for khugepaged tests to 
work\n");
+       fprintf(stderr, "\tmounted with huge=advise option for khugepaged tests to 
work\n");
        fprintf(stderr, "\n\tSupported Options:\n");
        fprintf(stderr, "\t\t-h: This help message.\n");
        fprintf(stderr, "\t\t-s: mTHP size, expressed as page order.\n");