disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.

Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver 
driver")
Signed-off-by: Jinjie Ruan <ruanjin...@huawei.com>
---
 drivers/net/ieee802154/mcr20a.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ieee802154/mcr20a.c b/drivers/net/ieee802154/mcr20a.c
index 433fb5839203..020d392a98b6 100644
--- a/drivers/net/ieee802154/mcr20a.c
+++ b/drivers/net/ieee802154/mcr20a.c
@@ -1302,16 +1302,13 @@ mcr20a_probe(struct spi_device *spi)
                irq_type = IRQF_TRIGGER_FALLING;
 
        ret = devm_request_irq(&spi->dev, spi->irq, mcr20a_irq_isr,
-                              irq_type, dev_name(&spi->dev), lp);
+                              irq_type | IRQF_NO_AUTOEN, dev_name(&spi->dev), 
lp);
        if (ret) {
                dev_err(&spi->dev, "could not request_irq for mcr20a\n");
                ret = -ENODEV;
                goto free_dev;
        }
 
-       /* disable_irq by default and wait for starting hardware */
-       disable_irq(spi->irq);
-
        ret = ieee802154_register_hw(hw);
        if (ret) {
                dev_crit(&spi->dev, "ieee802154_register_hw failed\n");
-- 
2.34.1


Reply via email to