On Tue, Jun 18, 2024 at 09:36:56AM +0000, Takaya Saeki wrote:
> + TP_printk(
> + "dev %d:%d ino %lx ofs=%lu max_ofs=%lu",
It seems weird to have a space between dev and %d, but an equals between
ofs and %lu. I see there is some precedent for this elsewhere, but
there are other places which use ino=. I'd rather:
"dev=%d:%d ino=%lx ofs=%lu max_ofs=%lu",
> + TP_printk(
> + "dev %d:%d ino %lx ofs=%lu",
Likewise.
> + MAJOR(__entry->s_dev),
> + MINOR(__entry->s_dev), __entry->i_ino,
> + __entry->index << PAGE_SHIFT
This needs to be cast to an loff_t before shifting.
