On Mon, 10 Jun 2024 17:40:52 -0400 Steven Rostedt <rost...@goodmis.org> wrote:
> On Tue, 11 Jun 2024 06:26:44 +0900 > "Masami Hiramatsu (Google)" <mhira...@kernel.org> wrote: > > > From: Masami Hiramatsu (Google) <mhira...@kernel.org> > > > > Since the kprobe-events selftest shows OK or NG with the reason, the > > WARN_ON_ONCE()s for each place are redundant. Let's remove it. > > Note, the ktests we run to validate commits, fail when it detects a WARN() > triggered. > > If this fails in any configuration, ktest will not detect it failed. Hmm, I think there are 2 options, - remove pr_warn() instead. (WARN_ON_ONCE + pr_warn is redundant) - Or, remove WARN_ON_ONCE() from each place, but add WARN_ON_ONCE() when `warn` is not zero. Thank you, > > -- Steve > > > > > > Signed-off-by: Masami Hiramatsu (Google) <mhira...@kernel.org> > > --- > > kernel/trace/trace_kprobe.c | 26 +++++++++++++------------- > > 1 file changed, 13 insertions(+), 13 deletions(-) > -- Masami Hiramatsu (Google) <mhira...@kernel.org>
