On 2/13/2024 10:58 AM, Eugenio Perez Martin wrote: > On Mon, Feb 12, 2024 at 6:16 PM Steve Sistare <steven.sist...@oracle.com> > wrote: >> >> Flush to guarantee no workers are running when suspend returns. >> >> Signed-off-by: Steve Sistare <steven.sist...@oracle.com> > > Acked-by: Eugenio Pérez <epere...@redhat.com> > > Should this have a Fixes tag?
Sure, I will add: Fixes: f345a0143b4d ("vhost-vdpa: uAPI to suspend the device") - Steve >> --- >> drivers/vhost/vdpa.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c >> index bc4a51e4638b..a3b986c24805 100644 >> --- a/drivers/vhost/vdpa.c >> +++ b/drivers/vhost/vdpa.c >> @@ -594,10 +594,13 @@ static long vhost_vdpa_suspend(struct vhost_vdpa *v) >> struct vdpa_device *vdpa = v->vdpa; >> const struct vdpa_config_ops *ops = vdpa->config; >> int ret; >> + struct vhost_dev *vdev = &v->vdev; >> >> if (!ops->suspend) >> return -EOPNOTSUPP; >> >> + vhost_dev_flush(vdev); >> + >> ret = ops->suspend(vdpa); >> if (!ret) >> v->suspended = true; >> -- >> 2.39.3 >> >