Mathieu Segaud <[EMAIL PROTECTED]> writes: > Signed-off-by: Mathieu Segaud <[EMAIL PROTECTED]> > --- > fs/ext4/dir.c | 2 +- > fs/ext4/file.c | 2 +- > fs/ext4/ioctl.c | 161 > ++++++++++++++++++++++++++++++++--------------- > include/linux/ext4_fs.h | 3 +- > 4 files changed, 112 insertions(+), 56 deletions(-) > > diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c > index f612bef..8f6677a 100644 > --- a/fs/ext4/dir.c > +++ b/fs/ext4/dir.c > @@ -42,7 +42,7 @@ const struct file_operations ext4_dir_operations = { > .llseek = generic_file_llseek, > .read = generic_read_dir, > .readdir = ext4_readdir, /* we take BKL. needed?*/ > - .ioctl = ext4_ioctl, /* BKL held */ > + .unlocked_ioctl = ext4_ioctl, /* BKL held */
Wasn't the purpose of this whole exercise to eventually allow them to be outside BKL? IOW, don't you want to drop this comment for the .unlocked_ioctl member of this struct? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/