From: Dexuan Cui <de...@microsoft.com>
Date: Thu, 8 Apr 2021 15:58:40 -0700
> +struct gdma_msg_hdr {
> + u32 hdr_type;
> + u32 msg_type;
> + u16 msg_version;
> + u16 hwc_msg_id;
> + u32 msg_size;
> +} __packed;
> +
> +struct gdma_dev_id {
> + union {
> + struct {
> + u16 type;
> + u16 instance;
> + };
> +
> + u32 as_uint32;
> + };
> +} __packed;
Please don't use __packed unless absolutely necessary. It generates
suboptimal code (byte at a time
accesses etc.) and for many of these you don't even need it.
Thank you.
