On 4/7/21 11:12 AM, Fenghua Yu wrote:
Hi, Shuah,
On Wed, Apr 07, 2021 at 08:33:23AM -0600, Shuah Khan wrote:
On 4/5/21 6:52 PM, Fenghua Yu wrote:
- ksft_print_msg("%s cache miss rate within %d%%\n",
- ret ? "Fail:" : "Pass:", max_diff_percent);
+ ksft_print_msg("Check cache miss rate within %d%%\n", max_diff_percent);
You need %s and pass in the ret ? "Fail:" : "Pass:" result for the
message to read correctly.
Should I keep the ":" after "Pass"/"Fail"?
Yes please.
I am seeing:
# Check kernel support for resctrl filesystem
It should say the following:
# Fail Check kernel support for resctrl filesystem
i.e. should the printed messages be like the following?
# Fail: Check kernel support for resctrl filesystem
or
# Pass: Check kernel support for resctrl filesystem
This looks good.
thanks,
-- Shuah
