Re: [PATCH 1/1] drm/msm/dpu: remove unused local variable 'cmd_enc'

[abhinavk]

On 2021-04-07 01:33, Zhen Lei wrote:

Fixes the following W=1 kernel build warning:

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c: In function
‘dpu_encoder_phys_cmd_wait_for_commit_done’:
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c:688:31: warning:
variable ‘cmd_enc’ set but not used [-Wunused-but-set-variable]

Fixes: fe286893ed34 ("drm/msm/dpu: Remove unused call in wait_for_commit_done")

Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Zhen Lei <thunder.leiz...@huawei.com>

Reviewed-by: Abhinav Kumar <abhin...@codeaurora.org>

---
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
index b2be39b9144e449..088900841bf8baa 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c

@@ -685,10 +685,6 @@ static int dpu_encoder_phys_cmd_wait_for_tx_complete(

 static int dpu_encoder_phys_cmd_wait_for_commit_done(
                struct dpu_encoder_phys *phys_enc)
 {
-       struct dpu_encoder_phys_cmd *cmd_enc;
-
-       cmd_enc = to_dpu_encoder_phys_cmd(phys_enc);
-
        /* only required for master controller */
        if (!dpu_encoder_phys_cmd_is_master(phys_enc))
                return 0;