Re: [Outreachy kernel] [PATCH 1/2] staging: media: omap4iss: Ending line with argument

[Beatriz Martins de Carvalho]

Em 01/04/21 16:28, Matthew Wilcox escreveu:

On Thu, Apr 01, 2021 at 04:07:38PM +0100, Beatriz Martins de Carvalho wrote:

diff --git a/drivers/staging/media/omap4iss/iss.c 
b/drivers/staging/media/omap4iss/iss.c
index dae9073e7d3c..e8f724dbf810 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
        iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
                    ISS_HL_SYSCONFIG_SOFTRESET);

- timeout = iss_poll_condition_timeout(

-               !(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-               ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
+       timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+                                                           OMAP4_ISS_MEM_TOP, 
ISS_HL_SYSCONFIG)
+                                                           & 
ISS_HL_SYSCONFIG_SOFTRESET),
+                                                           1000, 10, 100);

This is not a readability improvment.  I would factor it out into its
own function.

Thanks for the review. How can I do this? I don't know how to do this.
Beatriz Martins de Carvalho