On Mon, 2008-01-21 at 09:56 +0000, Christoph Hellwig wrote: > On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: > > aha152x.c and fdomain are built twice - once for the isa driver and > > once for the PCMCIA one. Through #ifdefs, the compiled codes are > > slightly different; thus, global symbols need to be given different > > names depending on which flavor is being built. This patch adds > > GLOBAL() macro to aha152x.h and fdomain.h which change the symbol > > depending on PCMCIA. > > > > This bug has always existed but has been masked by the fact the > > drivers/scsi/pcmcia used subdir-(y|m) instead of obj-(y|m) which made > > drivers/scsi/pcmcia/built_in.o not linked into the kernel and thus > > avoided the duplicate symbols during compilation. > > The right fix would be to compile it only once and attach it to both > busses. It would be nice if someone could look into that instead of > hacking around the issue.
I agree in principle, but without the hardware such a change would be untested ... which is what makes me worry about it. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
