On 4/1/21 12:47 AM, Oleksij Rempel wrote: > On Wed, Mar 31, 2021 at 02:27:19PM +0200, Andrew Lunn wrote: >> On Tue, Mar 30, 2021 at 03:54:07PM +0200, Oleksij Rempel wrote: >>> Port some parts of the stmmac selftest to the FEC. This patch was tested >>> on iMX6DL. >>> With this tests it is possible to detect some basic issues like: >>> - MAC loopback fail: most probably wrong clock configuration. >>> - PHY loopback fail: incorrect RGMII timings, damaged traces, etc >> >> Hi >> >> Oleksij >> >> I've not done a side-by-side diff with stmmac, but i guess a lot of >> this code is identical? > > ack > >> Rather than make a copy/paste, could you move >> it somewhere under net and turn it into a library any driver can use? > > yes, I assume, it is possible to make this code complete generic for all > devices, but we will need to provide some more call backs. For example > enable MAC loop back, enable DSA loopbacks and so on. > > Do you have ideas for the new location of generic selftest code and > where can be added loopback options for different levels?
You could place the generic selftest code under net/core/ or net/ethernet. -- Florian
