Re: [PATCH -next] staging: rtl8723bs: os_dep: remove unused variable 'ret'

[Yang Yingliang]

Hi,

On 2021/3/31 18:27, Greg KH wrote:
On Wed, Mar 31, 2021 at 05:42:47PM +0800, Yang Yingliang wrote:
GCC reports the following warning with W=1:
drivers/staging/rtl8723bs/os_dep/recv_linux.c:101:6: warning:
  variable ‘ret’ set but not used [-Wunused-but-set-variable]
   101 |  int ret;
       |      ^~~

This variable is not used in function , this commit
remove it to fix the warning.

Fixes: de69e2b3f105 ("staging: rtl8723bs: remove DBG_COUNTER calls from 
os_dep/recv_linux.c")
Reported-by: Hulk Robot <hul...@huawei.com>
Signed-off-by: Yang Yingliang <yangyingli...@huawei.com>
---
  drivers/staging/rtl8723bs/os_dep/recv_linux.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c 
b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
index fbdbcd04d44a..f6a9482be8e3 100644
--- a/drivers/staging/rtl8723bs/os_dep/recv_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
@@ -98,7 +98,6 @@ struct sk_buff *rtw_os_alloc_msdu_pkt(union recv_frame 
*prframe, u16 nSubframe_L
  void rtw_os_recv_indicate_pkt(struct adapter *padapter, struct sk_buff *pkt, 
struct rx_pkt_attrib *pattrib)
  {
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
-       int ret;
  
  	/* Indicate the packets to upper layer */
        if (pkt) {
@@ -140,7 +139,7 @@ void rtw_os_recv_indicate_pkt(struct adapter *padapter, 
struct sk_buff *pkt, str
  
  		pkt->ip_summed = CHECKSUM_NONE;
  
-		ret = rtw_netif_rx(padapter->pnetdev, pkt);
+               rtw_netif_rx(padapter->pnetdev, pkt);
Why not handle the result of this call properly?

The return type of rtw_os_recv_indicate_pkt() is void, it can't use this 
return code.

I will try to make a patch to change return type of 
rtw_os_recv_indicate_pkt() to use
this return code later.

Thanks,

Yang


.