On Sat, Mar 27, 2021 at 03:33:57PM -0500, Rob Herring wrote:
> The 'spi-nor' compatible used in the example is not documented. Use the
> documented 'jedec,spi-nor' compatible instead.
> 
> Cc: Mark Brown <broo...@kernel.org>
> Cc: Thierry Reding <thierry.red...@gmail.com>
> Cc: Jonathan Hunter <jonath...@nvidia.com>
> Cc: linux-...@vger.kernel.org
> Cc: linux-te...@vger.kernel.org
> Signed-off-by: Rob Herring <r...@kernel.org>
> ---
>  Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Ugg, I guess I should have tested this first:

Documentation/devicetree/bindings/spi/nvidia,tegra210-quad.example.dt.yaml: 
flash@0: 'nvidia,rx-clk-tap-delay', 'nvidia,tx-clk-tap-delay' do not match any 
of the regexes: '^partition@', 'pinctrl-[0-9]+'
        From schema: 
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml


This issue has come up a couple of times recently. There's not really an 
easy fix for this other than dropping the properties from the example 
and that doesn't help for actual dts file checks.

The issue is nvidia,tegra210-quad.yaml is applied to the SPI controller 
node and jedec,spi-nor.yaml is applied to the child node. Since those 
are independent, there's never a single schema with all possible child 
properties.

We could have a schema listing all these slave properties and every SPI 
slave binding has to reference that schema.

Rob

Reply via email to