On Wed, Mar 3, 2021 at 4:50 PM Lee Jones <lee.jo...@linaro.org> wrote: > On Wed, 03 Mar 2021, Alexandre Belloni wrote: > > On 03/03/2021 12:41:49+0000, Lee Jones wrote: > > > Both the caller and the supplier's source file should have access to > > > the include file containing the prototypes. > > > > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/pinctrl/pinctrl-at91.c:1637:6: warning: no previous prototype > > > for ‘at91_pinctrl_gpio_suspend’ [-Wmissing-prototypes] > > > 1637 | void at91_pinctrl_gpio_suspend(void) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > > drivers/pinctrl/pinctrl-at91.c:1661:6: warning: no previous prototype > > > for ‘at91_pinctrl_gpio_resume’ [-Wmissing-prototypes] > > > 1661 | void at91_pinctrl_gpio_resume(void) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > > > > Cc: Russell King <li...@armlinux.org.uk> > > > Cc: Nicolas Ferre <nicolas.fe...@microchip.com> > > > Cc: Alexandre Belloni <alexandre.bell...@bootlin.com> > > > Cc: Ludovic Desroches <ludovic.desroc...@microchip.com> > > > Signed-off-by: Lee Jones <lee.jo...@linaro.org> > > > > I'm pretty sure you had my ack on v3 ;) > > > > Acked-by: Alexandre Belloni <alexandre.bell...@bootlin.com> > > > > or again, alternatively, I can apply it with Linus' ack > > That would be my preference, thanks.
Acked-by: Linus Walleij <linus.wall...@linaro.org> Yours, Linus Walleij