From: Guoqing Jiang <guoqing.ji...@cloud.ionos.com>

[ Upstream commit e6ab8cf50fa1c38652feba3e4921c60538236f30 ]

Since the three functions share the similar logic, let's introduce one
common function for it.

Link: 
https://lore.kernel.org/r/20201023074353.21946-12-jinpu.w...@cloud.ionos.com
Signed-off-by: Guoqing Jiang <guoqing.ji...@cloud.ionos.com>
Signed-off-by: Jack Wang <jinpu.w...@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <j...@nvidia.com>
Signed-off-by: Sasha Levin <sas...@kernel.org>
---
 drivers/infiniband/ulp/rtrs/rtrs.c | 52 +++++++++++-------------------
 1 file changed, 19 insertions(+), 33 deletions(-)

diff --git a/drivers/infiniband/ulp/rtrs/rtrs.c 
b/drivers/infiniband/ulp/rtrs/rtrs.c
index 8321e8a52045..97af8f0bb806 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs.c
@@ -104,6 +104,22 @@ int rtrs_post_recv_empty(struct rtrs_con *con, struct 
ib_cqe *cqe)
 }
 EXPORT_SYMBOL_GPL(rtrs_post_recv_empty);
 
+static int rtrs_post_send(struct ib_qp *qp, struct ib_send_wr *head,
+                            struct ib_send_wr *wr)
+{
+       if (head) {
+               struct ib_send_wr *tail = head;
+
+               while (tail->next)
+                       tail = tail->next;
+               tail->next = wr;
+       } else {
+               head = wr;
+       }
+
+       return ib_post_send(qp, head, NULL);
+}
+
 int rtrs_iu_post_send(struct rtrs_con *con, struct rtrs_iu *iu, size_t size,
                       struct ib_send_wr *head)
 {
@@ -126,17 +142,7 @@ int rtrs_iu_post_send(struct rtrs_con *con, struct rtrs_iu 
*iu, size_t size,
                .send_flags = IB_SEND_SIGNALED,
        };
 
-       if (head) {
-               struct ib_send_wr *tail = head;
-
-               while (tail->next)
-                       tail = tail->next;
-               tail->next = &wr;
-       } else {
-               head = &wr;
-       }
-
-       return ib_post_send(con->qp, head, NULL);
+       return rtrs_post_send(con->qp, head, &wr);
 }
 EXPORT_SYMBOL_GPL(rtrs_iu_post_send);
 
@@ -168,17 +174,7 @@ int rtrs_iu_post_rdma_write_imm(struct rtrs_con *con, 
struct rtrs_iu *iu,
                if (WARN_ON(sge[i].length == 0))
                        return -EINVAL;
 
-       if (head) {
-               struct ib_send_wr *tail = head;
-
-               while (tail->next)
-                       tail = tail->next;
-               tail->next = &wr.wr;
-       } else {
-               head = &wr.wr;
-       }
-
-       return ib_post_send(con->qp, head, NULL);
+       return rtrs_post_send(con->qp, head, &wr.wr);
 }
 EXPORT_SYMBOL_GPL(rtrs_iu_post_rdma_write_imm);
 
@@ -195,17 +191,7 @@ int rtrs_post_rdma_write_imm_empty(struct rtrs_con *con, 
struct ib_cqe *cqe,
                .ex.imm_data    = cpu_to_be32(imm_data),
        };
 
-       if (head) {
-               struct ib_send_wr *tail = head;
-
-               while (tail->next)
-                       tail = tail->next;
-               tail->next = &wr;
-       } else {
-               head = &wr;
-       }
-
-       return ib_post_send(con->qp, head, NULL);
+       return rtrs_post_send(con->qp, head, &wr);
 }
 EXPORT_SYMBOL_GPL(rtrs_post_rdma_write_imm_empty);
 
-- 
2.30.1



Reply via email to