* Yinghai Lu <[EMAIL PROTECTED]> wrote: > - printk(KERN_INFO "CPU %d: aperture @ %Lx size %u MB\n", > - num-24, aper_base, aper_size>>20); > + printk(KERN_INFO "Node %d: aperture @ %Lx size %u MB\n", > + node++, aper_base, aper_size >> 20);
please dont put side-effects into printks. (put the node++ iteration out into a separate line) Your patch looks fine otherwise. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/