On Wed, Mar 10, 2021 at 10:27:53PM +0000, Eric Curtin wrote: > Hi Fabio, > > > I am sorry, I fear I don't understand, checkpatch.sh script says the patch > > is ok. > > Where have I to add a ' ' (a blank?)? > > > > thank you, > > > > fabio > > > > I'm only responding to this because this email is doing a very good job > of avoiding my filters somehow :) I think what Greg means is: > > Change this: > > /* > -op_mode > -Set to 0 (HT pure) under the following conditions > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > -Set to 1 (HT non-member protection) if there may be non-HT STAs > - in both the primary and the secondary channel > -Set to 2 if only HT STAs are associated in BSS, > - however and at least one 20 MHz HT STA is associated > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > - (currently non-GF HT station is considered as non-HT STA also) > -*/ > + *op_mode > + *Set to 0 (HT pure) under the following conditions > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > + *Set to 1 (HT non-member protection) if there may be non-HT STAs > + * in both the primary and the secondary channel > + *Set to 2 if only HT STAs are associated in BSS, > + * however and at least one 20 MHz HT STA is associated > + *Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > + * (currently non-GF HT station is considered as non-HT STA also) > + */ > > to this: > > /* > -op_mode > -Set to 0 (HT pure) under the following conditions > - - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > - - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > -Set to 1 (HT non-member protection) if there may be non-HT STAs > - in both the primary and the secondary channel > -Set to 2 if only HT STAs are associated in BSS, > - however and at least one 20 MHz HT STA is associated > -Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > - (currently non-GF HT station is considered as non-HT STA also) > -*/ > + * op_mode > + * Set to 0 (HT pure) under the following conditions > + * - all STAs in the BSS are 20/40 MHz HT in 20/40 MHz BSS or > + * - all STAs in the BSS are 20 MHz HT in 20 MHz BSS > + * Set to 1 (HT non-member protection) if there may be non-HT STAs > + * in both the primary and the secondary channel > + * Set to 2 if only HT STAs are associated in BSS, > + * however and at least one 20 MHz HT STA is associated > + * Set to 3 (HT mixed mode) when one or more non-HT STAs are associated > + * (currently non-GF HT station is considered as non-HT STA also) > + * / > > Like Dan said, you need a space after the '*'/ > > Is mise le meas/Regards, > > Eric Curtin > > Check out this charity that's close to my heart: > > https://www.idonate.ie/fundraiser/11394438_peak-for-pat.html > https://www.facebook.com/Peak-for-Pat-104470678280309 > https://www.instagram.com/peakforpat/
Thank you Eric, community is the best resource ever :), hope to contribute soon Kind regards, Fabio
