On Fri, 2008-01-11 at 18:08 +0000, Alan Cox wrote: > This lets us remove port 0x80 use on the PCI systems. It also speeds > up > some of the later 8390 based cores where we know the device does not > need > delay loops either because it has internal handling or in most cases a > faster device anyway. > > We compile up a new module 8390p to go with 8390 one with delays and > one > without. Most users will never need 8390p so it seems best to produce > two > modules.
> diff -u --new-file --recursive --exclude-from /usr/src/exclude > linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c > linux-2.6.24-rc6-mm1/drivers/net/hp.c > --- linux.vanilla-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-02 > 16:04:00.000000000 +0000 > +++ linux-2.6.24-rc6-mm1/drivers/net/hp.c 2008-01-11 14:47:44.000000000 > +0000 > @@ -176,7 +176,7 @@ > outb_p(irqmap[irq] | HP_RUN, ioaddr + > HP_CONFIGURE); > outb_p( 0x00 | HP_RUN, ioaddr + HP_CONFIGURE); ... didn't you miss two here? Otherwise, code looks great. How will the user know when they need to use 8390p? Should you perhaps default to producing and using 8390p if CONFIG_ISA is on? Zach -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
