On 01/10/2008 03:28 PM, Randy Dunlap wrote: > On Thu, 10 Jan 2008 20:15:53 +0100 Roel Kluin wrote: > >> Totally untested patch below from linus' git tree. The && is incorrect, >> right? >> >> from drivers/net/wireless/arlan.h:390: >> #define ARLAN_POWER 0x40 >> #define ARLAN_ACCESS 0x80 >> >> Replace logical and by bit-and >> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >> --- >> diff --git a/drivers/net/wireless/arlan.h b/drivers/net/wireless/arlan.h >> index 3ed1df7..7b7498f 100644 >> --- a/drivers/net/wireless/arlan.h >> +++ b/drivers/net/wireless/arlan.h >> @@ -485,7 +485,7 @@ struct arlan_private { >> #define clearClearInterrupt(dev){\ >> writeControlRegister(dev,readControlRegister(dev) & >> ~ARLAN_CLEAR_INTERRUPT);} >> #define setPowerOff(dev){\ >> - writeControlRegister(dev,readControlRegister(dev) | (ARLAN_POWER && >> ARLAN_ACCESS));\ >> + writeControlRegister(dev, readControlRegister(dev) | (ARLAN_POWER & >> ARLAN_ACCESS));\ > > eh? How does that help? > > 0x80 && 0x40 -> 0
1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/