From: Mikulas Patocka <mpato...@redhat.com>

commit cb728484a7710c202f02b96aa0962ce9b07aa5c2 upstream.

Fix a thinko in ssd_commit_superblock. region.count is in sectors, not
bytes. This bug doesn't corrupt data, but it causes performance
degradation.

Signed-off-by: Mikulas Patocka <mpato...@redhat.com>
Fixes: dc8a01ae1dbd ("dm writecache: optimize superblock write")
Cc: sta...@vger.kernel.org # v5.7+
Reported-by: J. Bruce Fields <bfie...@redhat.com>
Signed-off-by: Mike Snitzer <snit...@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/md/dm-writecache.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -523,7 +523,7 @@ static void ssd_commit_superblock(struct
 
        region.bdev = wc->ssd_dev->bdev;
        region.sector = 0;
-       region.count = PAGE_SIZE;
+       region.count = PAGE_SIZE >> SECTOR_SHIFT;
 
        if (unlikely(region.sector + region.count > wc->metadata_sectors))
                region.count = wc->metadata_sectors - region.sector;


Reply via email to