Re: [PATCH] wilc1000: write value to WILC_INTR2_ENABLE register

[Ajay.Kathat]

On 24/02/21 10:13 pm, Kalle Valo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the 
> content is safe
> 
> Marcus Folkesson <marcus.folkes...@gmail.com> writes:
> 
>> Write the value instead of reading it twice.
>>
>> Fixes: 5e63a598441a ("staging: wilc1000: added 'wilc_' prefix for function 
>> in wilc_sdio.c file")
>>
>> Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com>
>> ---
>>  drivers/net/wireless/microchip/wilc1000/sdio.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/microchip/wilc1000/sdio.c 
>> b/drivers/net/wireless/microchip/wilc1000/sdio.c
>> index 351ff909ab1c..e14b9fc2c67a 100644
>> --- a/drivers/net/wireless/microchip/wilc1000/sdio.c
>> +++ b/drivers/net/wireless/microchip/wilc1000/sdio.c
>> @@ -947,7 +947,7 @@ static int wilc_sdio_sync_ext(struct wilc *wilc, int 
>> nint)
>>                       for (i = 0; (i < 3) && (nint > 0); i++, nint--)
>>                               reg |= BIT(i);
>>
>> -                     ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, 
>> &reg);
>> +                     ret = wilc_sdio_write_reg(wilc, WILC_INTR2_ENABLE, 
>> reg);
> 
> To me it looks like the bug existed before commit 5e63a598441a:


Yes, you are correct. The bug existed from commit c5c77ba18ea6:

https://git.kernel.org/linus/c5c77ba18ea6

Regards,
Ajay

> 
> -                       ret = sdio_read_reg(wilc, WILC_INTR2_ENABLE, &reg);
> +                       ret = wilc_sdio_read_reg(wilc, WILC_INTR2_ENABLE, 
> &reg);
> 
> https://git.kernel.org/linus/5e63a598441a
> 
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
> 
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>