On Wednesday 09 January 2008 03:18:46 Ingo Molnar wrote: > * DM <[EMAIL PROTECTED]> wrote: > > On Jan 8, 2008 3:26 PM, Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > > > Why use sprintf? If a module name contains the % character we could > > > > overflow the buffer. Or is module-unloading root-only and we don't > > > > care? > > > > > > module loading isn't just root only; the name comes from an already > > > loaded module. If you can load kernel modules of your choice you own > > > the entire kernel already anway > > > > Still, strcpy seems like a better choice IMHO. > > agreed, this just isnt obvious IMO: > > + sprintf(last_unloaded_module, mod->name); > > Ingo
Yes, I've changed it to: + strlcpy(last_unloaded_module, mod->name, sizeof(last_unloaded_module)); In my tree. Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
