On Mon, 22 Feb 2021, Zheng Yejian wrote: > From: Peter Zijlstra <pet...@infradead.org> > > commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. > > Both Geert and DaveJ reported that the recent futex commit: > > c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > > introduced a problem with setting OWNER_DEAD. We set the bit on an > uninitialized variable and then entirely optimize it away as a > dead-store. > > Move the setting of the bit to where it is more useful. > > Reported-by: Geert Uytterhoeven <ge...@linux-m68k.org> > Reported-by: Dave Jones <da...@codemonkey.org.uk> > Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org> > Cc: Andrew Morton <a...@linux-foundation.org> > Cc: Linus Torvalds <torva...@linux-foundation.org> > Cc: Paul E. McKenney <paul...@us.ibm.com> > Cc: Peter Zijlstra <pet...@infradead.org> > Cc: Thomas Gleixner <t...@linutronix.de> > Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") > Link: > http://lkml.kernel.org/r/20180122103947.gd2...@hirez.programming.kicks-ass.net > Signed-off-by: Ingo Molnar <mi...@kernel.org> > Signed-off-by: Zheng Yejian <zhengyeji...@huawei.com> > --- > kernel/futex.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Lee Jones <lee.jo...@linaro.org> -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog