Re: [PATCH 1/8] arm64: dts: imx8mm-nitrogen-r2: add wifi/bt chip

[Krzysztof Kozlowski]

On Tue, Feb 16, 2021 at 12:19:36AM +0100, Adrien Grassein wrote:
> Add usdhc3 description which corresponds to the wifi/bt chip
> 
> Signed-off-by: Adrien Grassein <adrien.grass...@gmail.com>
> ---
>  .../boot/dts/freescale/imx8mm-nitrogen-r2.dts | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts 
> b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> index c0c384d76147..bf20a40bcda0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-nitrogen-r2.dts
> @@ -9,6 +9,18 @@
>  / {
>       model = "Boundary Devices i.MX8MMini Nitrogen8MM Rev2";
>       compatible = "boundary,imx8mm-nitrogen8mm", "fsl,imx8mm";
> +
> +     reg_wlan_vmmc: regulator-wlan-vmmc {
> +             compatible = "regulator-fixed";
> +             pinctrl-names = "default";
> +             pinctrl-0 = <&pinctrl_reg_wlan_vmmc>;
> +             regulator-name = "reg_wlan_vmmc";
> +             regulator-min-microvolt = <3300000>;
> +             regulator-max-microvolt = <3300000>;
> +             gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> +             enable-active-high;
> +             startup-delay-us = <70000>;

That's quite a startup time... and it happens is the same as in bindings
example. Do you really need it or it was just copied?

I actually don't mind it, just poking at various things. :)

> +     };
>  };
>  
>  &A53_0 {
> @@ -206,6 +218,19 @@ &usdhc2 {
>       status = "okay";
>  };
>  
> +/* wlan */
> +&usdhc3 {
> +     bus-width = <4>;
> +     sdhci-caps-mask = <0x2 0x0>;
> +     non-removable;
> +     pinctrl-names = "default", "state_100mhz", "state_200mhz";
> +     pinctrl-0 = <&pinctrl_usdhc3>;
> +     pinctrl-1 = <&pinctrl_usdhc3_100mhz>;
> +     pinctrl-2 = <&pinctrl_usdhc3_200mhz>;
> +     vmmc-supply = <&reg_wlan_vmmc>;

What about vqmmc?

Best regards,
Krzysztof