Hi, 2008/1/7, Anton Vorontsov <[EMAIL PROTECTED]>: > On Mon, Jan 07, 2008 at 01:15:32AM +0300, Dmitry wrote: > [...] > > > > + POWER_SUPPLY_ATTR(voltage_max), > > > > + POWER_SUPPLY_ATTR(voltage_min), > > > > > > I'd suggest keep Documentation/power_supply_class.txt in sync > > > wrt new properties, to distinct their meanings and usage. > > > > > > I assume you're using these new properties for non-rechargeable > > > LiMn batteries. So, why new properties, aren't voltage_*_design > > > ones suits that purpose? If battery is non-rechargeable it is > > > having only design values, no? > > > > No, I used it for the battery driver for Sharp Zaurus SL-6000 (tosa). > > It's connected via simple ADC so I can get only voltages. I don't know > > max_design value for the battery, but I have 'FULL' signal which I use > > to detect 'voltage_max' and use it for power estimations. > > Ah, I see. In that case the value is empiric and voltage_max is > appropriate name indeed.
:) Documentation patch should be pretty trivial, could you please just make it w/o another resent cycle? > > Thanks, > > -- > Anton Vorontsov > email: [EMAIL PROTECTED] > backup email: [EMAIL PROTECTED] > irc://irc.freenode.net/bd2 > -- With best wishes Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
