On Wed, 2021-02-10 at 13:21 -0800, Drew Fustini wrote: > I will change from the incorrect 0400 to 0444.
Thanks. > As for S_IFREG, it does seem like leaving off S_IFREG is the most common > case when using octal permissions with debugfs_create_*(): > > $ git grep debugfs_create drivers/ |grep 0444 |grep -v S_IFREG | wc -l > 302 > $ git grep debugfs_create drivers/ |grep 0444 |grep S_IFREG | wc -l > 9 It's ~2:1 when using S_IRUGO $ git grep debugfs_create_file drivers/ | grep S_IRUGO | grep -v S_IFREG | wc -l 109 $ git grep debugfs_create_file drivers/ | grep S_IRUGO | grep S_IFREG | wc -l 48
