Sorry for polluting, On Fri, Feb 05, 2021 at 12:40:54AM +0000, Giancarlo Ferrari wrote: > Russell, > > On Fri, Feb 05, 2021 at 12:18:33AM +0000, Russell King - ARM Linux admin > wrote: > > On Thu, Feb 04, 2021 at 11:48:42PM +0000, Giancarlo Ferrari wrote: > > > Can I ask about having it integrated ? > > > > Thanks for testing. Are you willing for me to add: > > > > Tested-by: Giancarlo Ferrari <giancarlo.ferrar...@gmail.com> > > > > to the commit log? > > > > Sure. > > I have a question regarding the patch. I saw that the structure start at > the end of the relocation code: > > data = reboot_code_buffer + relocate_new_kernel_size; > > which means it overlap with the global symbol relocate_new_kernel_size. > I think is minor comment as the variable is only used in the fncpy() > then thrown away. Something like: > > data = reboot_code_buffer + relocate_new_kernel_size + sizeof(long); > > and accordingly in the instruction (arch/arm/kernel/relocate_kernel.S): > > adr r7, relocate_new_kernel_end >
my fault. Do as I didn't talk... one is in virtual memory the other in the initial code. > > I can move it into the fixes branch which I want to send to Linus by > > Saturday at the very latest. > > > > I am not used with all the merging process. However it sounds great ! > > > -- > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > Thanks in advance, > > > GF Thanks, GF
