On Wed, 2 Jan 2008, Linus Torvalds wrote:
> 
> Actually, I'd much rather just do this instead (on top of your patch)

Side note - and I didn't do this - this also allows you to disable 
slabinfo for those people who think it is pointless.

In particular, you could just make that

> +config SLABINFO
> +     bool
> +     depends on PROC_FS
> +     depends on SLAB || SLUB
> +     default y

Kconfig entry use something like

        bool "Enable /proc/slabinfo support"

(perhaps adding an "if EMBEDDED" at the end), and now people can decide 
whether they actually want it or not (independently of whether they use 
SLUB or SLAB or whatever). But I left it hardcoded to on, just because I'm 
not sure it's worth it.

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to