> -----Original Message----- > From: Arnd Bergmann <a...@kernel.org> > Sent: Monday, January 25, 2021 11:45 PM > To: mgr...@linux.intel.com > Cc: Randy Dunlap <rdun...@infradead.org>; markgr...@kernel.org; Arnd > Bergmann <a...@arndb.de>; Borislav Petkov <b...@suse.de>; Damien Le Moal > <damien.lem...@wdc.com>; Dragan Cvetic <dragan.cve...@xilinx.com>; gregkh > <gre...@linuxfoundation.org>; Jonathan Corbet <cor...@lwn.net>; Leonard > Crestez <leonard.cres...@nxp.com>; Palmer Dabbelt > <palmerdabb...@google.com>; Paul Walmsley <paul.walms...@sifive.com>; > Peng Fan <peng....@nxp.com>; Rob Herring <robh...@kernel.org>; Shawn > Guo <shawn...@kernel.org>; Jassi Brar <jassisinghb...@gmail.com>; linux- > ker...@vger.kernel.org; C, Udhayakumar <udhayakuma...@intel.com>; > c...@linux.intel.com > Subject: Re: [PATCH v2 29/34] Intel tsens i2c slave driver. > > On Tue, Jan 26, 2021 at 12:39 AM mark gross <mgr...@linux.intel.com> wrote: > > > > On Mon, Jan 11, 2021 at 11:15:06PM -0800, Randy Dunlap wrote: > > > On 1/8/21 1:25 PM, mgr...@linux.intel.com wrote: > > > > diff --git a/drivers/misc/intel_tsens/Kconfig > > > > b/drivers/misc/intel_tsens/Kconfig > > > > index 8b263fdd80c3..c2138339bd89 100644 > > > > --- a/drivers/misc/intel_tsens/Kconfig > > > > +++ b/drivers/misc/intel_tsens/Kconfig > > > > @@ -14,6 +14,20 @@ config INTEL_TSENS_LOCAL_HOST > > > > Say Y if using a processor that includes the Intel VPU such as > > > > Keem Bay. If unsure, say N. > > > > > > > > +config INTEL_TSENS_I2C_SLAVE > > > > + bool "I2C slave driver for intel tsens" > > > > > > Why bool instead of tristate? > > Becuase the I2C driver depends on a file scoped global i2c_plat_data > > instanciated in the INTELL_TSENS_LOCAL_HOST DRIVER > > (intel_tsens_thermal.[ch]) > > > > Udhaya, would you care to comment further? > > > > > + depends on INTEL_TSENS_LOCAL_HOST > > > > + select I2C > > > > + select I2C_SLAVE > > Please make this 'depends on I2C=y && I2C_SLAVE' instead of 'select' > in this case. A random driver should never force-enable another subsystem. Will do, thanks for the feedback!
--mark
