> That means we have two options: > (a) define __hyp_panic_string in a different .c file in all pre-5.9 branches, > or > (b) revert the backported patch. > > The patch was needed in 5.9 and should stay there. It wasn't needed in earlier > versions because the symbol was being kept alive by another user. It did "fix" > the inline asm semantics, but the problem was never triggered in pre-5.9. > > Sasha, with this and the GCC bug in mind, would you agree that (b) is the > better course of action?
Sasha, Any chance we can get this patch reverted as David has suggested? It was backported to 5.4 LTS in commit 653ae33b030b ("KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe") and is causing build issues with a 4.9.4 vintage of GCC. Thanks! -- Oliver