* Masami Hiramatsu <[EMAIL PROTECTED]> wrote:
> > Why is a macro better than an inline, and why the odd mIXed case?
>
> I thought we can use macro because it just check a bit mask. And if we
> use this as a macro, it will be defined in #ifdef block at the top of
> kprobes.c. It is simple in this case. I know the inline is better than
> the macro, it can check the type of arguments. If you would like to
> use inline, how about this?
yes, we prefer inlines for just about everything. We have reoccuring
regressions due to macro side-effects, lack of type and argument
checking - and the simplest maintenance policy is to just never
introduce new macros. Macros also played an active role in creating our
current include file dependencies spaghetti. So unless there are very,
very strong reasons in favor of adding a macro, please always use
inlines.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
