Hi Saravana, On Mon, Jan 18, 2021 at 11:14 PM Saravana Kannan <[email protected]> wrote: > On Mon, Jan 18, 2021 at 7:32 AM Linus Walleij <[email protected]> > wrote: > > On Fri, Jan 15, 2021 at 10:02 PM Saravana Kannan <[email protected]> > > wrote: > > > To provide backward compatibility for boards that use deprecated DT > > > bindings, we need to add fw_devlink support for "gpio" and "gpios". > > > > > > Cc: linux-tegra <[email protected]> > > > Cc: Linus Walleij <[email protected]> > > > Cc: Bartosz Golaszewski <[email protected]> > > > Cc: Greg Kroah-Hartman <[email protected]> > > > Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") > > > Tested-by: Jon Hunter <[email protected]> > > > Signed-off-by: Saravana Kannan <[email protected]>
Thanks for your patch! > > "gpios" is a valid non legacy property I think. > > I checked :) Quoting the documentation [1]: > "While a non-existent <name> is considered valid for compatibility > reasons (resolving to the "gpios" property), it is not allowed for new > bindings." > > [1] - > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/gpio/gpio.txt#n8 > > > Anyways: > > Reviewed-by: Linus Walleij <[email protected]> > > Thanks! > > Greg/Rob, > > Can we pull this into driver-core-next please? It fixes issues on some > boards with fw_devlink=on. On r8a77951-salvator-xs.dts, it introduces one more failure: OF: /soc/i2c@e66d8000/gpio@20/pcie-sata-switch-hog: could not get #gpio-cells for /cpus/cpu@102 Seems like it doesn't parse gpios properties in GPIO hogs correctly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
