Hi Miguel! On 1/1/21 9:42 PM, Miguel Ojeda wrote: > On Fri, Jan 1, 2021 at 2:50 PM John Paul Adrian Glaubitz > <glaub...@physik.fu-berlin.de> wrote: >> >> Verified on my SH-7785LCR board. Boots fine. >> >> Tested-by: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> > > Thanks for testing, John! > > I think Masahiro was concerned about the error case (I assume you > tested the happy path).
Not sure about testing the error case though. How do I make request_irq() fail? > In any case, if no maintainer suggests something else, looks good to > me (and it is no worse than the status quo unless the `pr_err()` can > somehow kill it), so: > > Reviewed-by: Miguel Ojeda <oj...@kernel.org> I agree. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
