[RFC PATCH] x86/mce: Add ppin and microcode to mce trace

[Tony Luck]

Steven,

I've been remiss about updating the mce_record trace as new fields
have been added to "struct mce". What are the ABI implications of a
patch like the one below (sample only ... there are a couple more fields
that may need to be added)?

Are there any size limitations that I might hit adding more items to
this record?

Thanks

-Tony

---
 include/trace/events/mce.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/mce.h b/include/trace/events/mce.h
index 1391ada0da3b..cf0e8b9920b7 100644
--- a/include/trace/events/mce.h
+++ b/include/trace/events/mce.h
@@ -33,6 +33,8 @@ TRACE_EVENT(mce_record,
                __field(        u8,             cs              )
                __field(        u8,             bank            )
                __field(        u8,             cpuvendor       )
+               __field(        u64,            ppin            )
+               __field(        u32,            microcode       )
        ),
 
        TP_fast_assign(
@@ -53,9 +55,11 @@ TRACE_EVENT(mce_record,
                __entry->cs             = m->cs;
                __entry->bank           = m->bank;
                __entry->cpuvendor      = m->cpuvendor;
+               __entry->ppin           = m->ppin;
+               __entry->microcode      = m->microcode;
        ),
 
-       TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, 
ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PROCESSOR: 
%u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
+       TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, 
ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PROCESSOR: 
%u:%x, TIME: %llu, SOCKET: %u, APIC: %x, PPIN: %llx, MICROCODE: %x",
                __entry->cpu,
                __entry->mcgcap, __entry->mcgstatus,
                __entry->bank, __entry->status,
@@ -66,7 +70,7 @@ TRACE_EVENT(mce_record,
                __entry->cpuvendor, __entry->cpuid,
                __entry->walltime,
                __entry->socketid,
-               __entry->apicid)
+               __entry->apicid, __entry->ppin, __entry->microcode)
 );
 
 #endif /* _TRACE_MCE_H */
-- 
2.21.1