Parag Warudkar wrote: > > Use deferrable timer for watchdog. Reduces wakeups from idle per second.
no, we don't want this. We already allow the re-scheduling of the watchdog to be round_jiffies() modified so that it coincides with other interrupts. but at load time we don't want the timer to be postponed at all for up to a whole second. Since we're doing all sorts of initialization work anyway this is counterproductive anyway, and you really want the link to come up as soon as possible, which is exactly what the watchdog handles when it runs first. I can't possibly see any benefit from this other than that you just add up to a whole second to the initialization cycle, which is bad. Auke > > Signed-off-by: Parag Warudkar <[EMAIL PROTECTED]> > > --- linux-2.6/drivers/net/e1000/e1000_main.c 2007-12-07 > 10:04:39.000000000 -0500 > +++ linux-2.6-work/drivers/net/e1000/e1000_main.c 2007-12-18 > 20:38:38.000000000 -0500 > @@ -1030,7 +1030,7 @@ > adapter->tx_fifo_stall_timer.function = &e1000_82547_tx_fifo_stall; > adapter->tx_fifo_stall_timer.data = (unsigned long) adapter; > > - init_timer(&adapter->watchdog_timer); > + init_timer_deferrable(&adapter->watchdog_timer); > adapter->watchdog_timer.function = &e1000_watchdog; > adapter->watchdog_timer.data = (unsigned long) adapter; > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
