[AMD Public Use]
> -----Original Message-----
> From: Alexander Monakov <amona...@ispras.ru>
> Sent: Sunday, December 20, 2020 4:12 PM
> To: platform-driver-...@vger.kernel.org
> Cc: S-k, Shyam-sundar <shyam-sundar....@amd.com>; Hans de Goede
> <hdego...@redhat.com>; Deucher, Alexander
> <alexander.deuc...@amd.com>; linux-kernel@vger.kernel.org
> Subject: amd-pmc s2idle driver issues
>
> Hi folks,
>
> I've tried the "platform/x86: amd-pmc: Add AMD platform support for
> S2Idle"
> patch on my Acer Swift SF314-42 laptop (Renoir SoC, Ryzen 4500U CPU) and
> hit the following issues:
>
> 1. The driver doesn't bind to any device. It has the following binding table:
>
> +static const struct acpi_device_id amd_pmc_acpi_ids[] = {
> + {"AMDI0005", 0},
> + {"AMD0004", 0},
> + { }
> +};
>
> This laptop has "AMD0005" instead. Adding it to the list allows the driver to
> successfully probe.
>
> 2. The debugfs interface does not seem to be very helpful. It shows
>
> SMU FW Info: ffffffff
>
> It's not very informative. The code seems to be fetching SMU version from
> mmio, so I guess the file should be saying "FW version" rather than "FW
> Info", and then, I think version number is not supposed to be "-1".
>
Does your platform support modern standby? You may have to select between
legacy S3 and modern standby in the sbios.
>
> (and I'm afraid I cannot use the driver, as there seems to be an issue with
> GPU resume: sometimes the screen is frozen or black after resume, so I
> need to reboot the laptop :( )
We are still working through various platform specific sbios issues on some
renoir platforms. We'll be sending out the appropriate quirks to handle them
once we've sorted them all out.
Alex
