On Mon, 21 Dec 2020, Nathan Chancellor wrote:
> Clang warns:
>
> ../drivers/i3c/master/mipi-i3c-hci/core.c:780:21: warning: attribute
> declaration must precede definition [-Wignored-attributes]
> static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> ^
> ../include/linux/compiler_attributes.h:267:56: note: expanded from macro
> '__maybe_unused'
> #define __maybe_unused __attribute__((__unused__))
> ^
> ../include/linux/mod_devicetable.h:262:8: note: previous definition is
> here
> struct of_device_id {
> ^
> 1 warning generated.
>
> 'struct of_device_id' should not be split, as it is a type. Move the
> __maybe_unused attribute after the static and const qualifiers so that
> there are no warnings about this variable, period.
>
> Fixes: 95393f3e07ab ("i3c/master/mipi-i3c-hci: quiet maybe-unused variable
> warning")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1221
> Signed-off-by: Nathan Chancellor <natechancel...@gmail.com>
Acked-by: Nicolas Pitre <npi...@baylibre.com>
> ---
> drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c
> b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 500abd27fb22..1b73647cc3b1 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -777,7 +777,7 @@ static int i3c_hci_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static const struct __maybe_unused of_device_id i3c_hci_of_match[] = {
> +static const __maybe_unused struct of_device_id i3c_hci_of_match[] = {
> { .compatible = "mipi-i3c-hci", },
> {},
> };
>
> base-commit: 95393f3e07ab53855b91881692a4a5b52dcdc03c
> --
> 2.30.0.rc1
>
>
