Hi, On Mon, Dec 21, 2020 at 06:08:15AM +0000, Vaittinen, Matti wrote: > > On Fri, 2020-12-18 at 19:38 +0100, Guido Günther wrote: > > Use the typical startup times from the data sheet so boards get a > > reasonable default. Not setting any enable time can lead to board > > hangs > > when e.g. clocks are enabled too soon afterwards. > > > > This fixes gpu power domain resume on the Librem 5. > > > > Signed-off-by: Guido Günther <a...@sigxcpu.org> > > > > --- > > v2 > > - As per review comment by Matti Vaittinen > > > > https://lore.kernel.org/lkml/beba25e85db20649aa040fc0ae549895c9265f6f.ca...@fi.rohmeurope.com/ > > Use defines instead of plain values > > - As per review comment by Mark Brown > > https://lore.kernel.org/lkml/20201216130637.gc4...@sirena.org.uk/ > > Drop cover letter > > --- > > drivers/regulator/bd718x7-regulator.c | 27 ++++++++++++++++++++++++ > > include/linux/mfd/rohm-bd718x7.h | 30 > > Thanks again Guido. > I might have preferred having the defines in bd718x7-regulator.c as > they are not likely to be used outside this file. That would have
In fact that's where I had them first, then noticing other regulator related defines in the mfd header. I can shift those around need be. Cheers, -- Guido > strictly limited the change to regulator subsystem. Having them in the > header is still fine with me if it works for Mark & others. (I don't > think these defines need much of changes in the future). > > Reviewed-by: Matti Vaittinen <matti.vaitti...@fi.rohmeurope.com> > > > Best Regards > Matti Vaittinen >
