On 10.12.2020 22:29, Krzysztof Kozlowski wrote:
> The Samsung PMIC datasheets describe the interrupt line as active low
> with a requirement of acknowledge from the CPU. Without specifying the
> interrupt type in Devicetree, kernel might apply some fixed
> configuration, not necessarily working for this hardware.
>
> Fixes: 01e5d2352152 ("arm64: dts: exynos: Add dts file for Exynos5433-based
> TM2 board")
> Signed-off-by: Krzysztof Kozlowski <k...@kernel.org>
Tested-by: Marek Szyprowski <m.szyprow...@samsung.com>
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> index 03486a8ffc67..4c5106a0860d 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi
> @@ -388,7 +388,7 @@ &hsi2c_0 {
> pmic@66 {
> compatible = "samsung,s2mps13-pmic";
> interrupt-parent = <&gpa0>;
> - interrupts = <7 IRQ_TYPE_NONE>;
> + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> reg = <0x66>;
> samsung,s2mps11-wrstbi-ground;
>
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
