On Mon, 2020-12-14 at 17:14 +0100, Bean Huo wrote: > From: Bean Huo <bean...@micron.com> > > Current EM macro definition, we use stringize operator '#', which turns > the argument it precedes into a quoted string. Thus requires the symbol > of __print_symbolic() should be the string corresponding to the name of > the enum. > > However, we have other cases, the symbol and enum name are not the same, > we can redefine EM/EMe, but there will introduce some redundant codes. > This patch is to remove this restriction, let others reuse the current > EM/EMe definition.
I think the other way (adding new definitions for the cases when the name and string are different) is less error prone. > diff --git a/include/trace/events/ufs.h b/include/trace/events/ufs.h [] > +#define UFS_LINK_STATES \ > + EM(UIC_LINK_OFF_STATE, "UIC_LINK_OFF_STATE") \ > + EM(UIC_LINK_ACTIVE_STATE, "UIC_LINK_ACTIVE_STATE,") \ For instance: Like here where you added an unnecessary and unwanted comma
