On 12/12/2020 6:40 PM, Vladimir Oltean wrote:
> Right now, the following would happen for a switch driver that does not
> implement .port_fdb_add or .port_fdb_del.
>
> dsa_slave_switchdev_event returns NOTIFY_OK and schedules:
> -> dsa_slave_switchdev_event_work
> -> dsa_port_fdb_add
> -> dsa_port_notify(DSA_NOTIFIER_FDB_ADD)
> -> dsa_switch_fdb_add
> -> if (!ds->ops->port_fdb_add) return -EOPNOTSUPP;
> -> an error is printed with dev_dbg, and
> dsa_fdb_offload_notify(switchdev_work) is not called.
>
> We can avoid scheduling the worker for nothing and say NOTIFY_OK.
Not sure if this comment is intended to describe what is being added,
only if you have to respin, should this be NOTIFY_DONE?
> Because we don't call dsa_fdb_offload_notify, the static FDB entry will
> remain just in the software bridge.
>
> Signed-off-by: Vladimir Oltean <vladimir.olt...@nxp.com>
Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
--
Florian
