On 06/12/2020 05:12, Rasmus Villemoes <rasmus.villem...@prevas.dk> wrote:
> -----Original Message----- > From: Rasmus Villemoes <rasmus.villem...@prevas.dk> > Sent: 2020年12月6日 5:12 > To: Jakub Kicinski <k...@kernel.org> > Cc: Leo Li <leoyang...@nxp.com>; David S. Miller <da...@davemloft.net>; > Qiang Zhao <qiang.z...@nxp.com>; net...@vger.kernel.org; > linuxppc-...@lists.ozlabs.org; linux-kernel@vger.kernel.org; > linux-arm-ker...@lists.infradead.org; Vladimir Oltean > <vladimir.olt...@nxp.com> > Subject: Re: [PATCH 00/20] ethernet: ucc_geth: assorted fixes and > simplifications > > On 05/12/2020 21.53, Jakub Kicinski wrote: > > On Sat, 5 Dec 2020 20:17:23 +0100 Rasmus Villemoes wrote: > >> While trying to figure out how to allow bumping the MTU with the > >> ucc_geth driver, I fell into a rabbit hole and stumbled on a whole > >> bunch of issues of varying importance - some are outright bug fixes, > >> while most are a matter of simplifying the code to make it more > >> accessible. > >> > >> At the end of digging around the code and data sheet to figure out > >> how it all works, I think the MTU issue might be fixed by a > >> one-liner, but I'm not sure it can be that simple. It does seem to > >> work (ping -s X works for larger values of X, and wireshark confirms > >> that the packets are not fragmented). > >> > >> Re patch 2, someone in NXP should check how the hardware actually > >> works and make an updated reference manual available. > > > > Looks like a nice clean up on a quick look. > > > > Please separate patches 1 and 11 (which are the two bug fixes I see) > > I think patch 2 is a bug fix as well, but I'd like someone from NXP to > comment. It 's ok for me. Best Regards, Qiang Zhao
