On Fri, Dec 04, 2020 at 06:43:37PM -0700, Jerry Snitselaar wrote: > To try and detect potential interrupt storms that > have been occurring with tpm_tis devices it was suggested > to use kstat_irqs() to get the number of interrupts. > Since tpm_tis can be built as a module it needs kstat_irqs > exported.
I think you should also have a paragraph explicitly stating that i915_pmu.c contains a duplicate of kstat_irqs() because it is not exported as of today. It adds a lot more weight to this given that there is already existing mainline usage (kind of). > > Reported-by: kernel test robot <l...@intel.com> I'm not sure if this makes much sense. > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: Jarkko Sakkinen <jar...@kernel.org> > Cc: Jason Gunthorpe <j...@ziepe.ca> > Cc: Peter Huewe <peterhu...@gmx.de> > Cc: James Bottomley <james.bottom...@hansenpartnership.com> > Cc: Matthew Garrett <mj...@google.com> > Cc: Hans de Goede <hdego...@redhat.com> > Signed-off-by: Jerry Snitselaar <jsnit...@redhat.com> /Jarkko