Hi Daniel, I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.10-rc6 next-20201201] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Lezcano/platform-x86-drivers-acerhdf-Use-module_param_cb-to-set-get-polling-interval/20201203-062450 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3bb61aa61828499a7d0f5e560051625fd02ae7e4 config: x86_64-randconfig-a004-20201202 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/40fa9177042a71ae3df7c776d693d27bce63fce8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Daniel-Lezcano/platform-x86-drivers-acerhdf-Use-module_param_cb-to-set-get-polling-interval/20201203-062450 git checkout 40fa9177042a71ae3df7c776d693d27bce63fce8 # save the attached .config to linux build tree make W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/platform/x86/acerhdf.c:827:5: warning: no previous prototype for >> 'interval_set_uint' [-Wmissing-prototypes] 827 | int interval_set_uint(const char *val, const struct kernel_param *kp) | ^~~~~~~~~~~~~~~~~ drivers/platform/x86/acerhdf.c: In function 'interval_set_uint': drivers/platform/x86/acerhdf.c:829:2: error: 'ret' undeclared (first use in this function) 829 | ret = param_set_uint(val, kp); | ^~~ drivers/platform/x86/acerhdf.c:829:2: note: each undeclared identifier is reported only once for each function it appears in vim +/interval_set_uint +827 drivers/platform/x86/acerhdf.c 826 > 827 int interval_set_uint(const char *val, const struct kernel_param *kp) 828 { 829 ret = param_set_uint(val, kp); 830 if (ret) 831 return ret; 832 833 acerhdf_check_param(thz_dev); 834 835 return 0; 836 } 837 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
