On Mon, Nov 30, 2020 at 03:28:51PM +0800, [email protected] wrote:
> From: Lei Chen <[email protected]>
> 
> iomap_add_to_ioend append page on wpc->ioend->io_bio. If io_bio is full,
> iomap_chain_bio will allocate a new bio. So when bio_add_page is called,
> pages is guaranteed to be appended into wpc->ioend->io_bio. So we do not
> need to check if page can be merged. Thus it's a faster way to directly
> call __bio_add_page.

How much faster?

--D

> Signed-off-by: Lei Chen <[email protected]>
> ---
>  fs/iomap/buffered-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> index 10cc797..7a0631a 100644
> --- a/fs/iomap/buffered-io.c
> +++ b/fs/iomap/buffered-io.c
> @@ -1310,7 +1310,7 @@ static void iomap_writepage_end_bio(struct bio *bio)
>                       wpc->ioend->io_bio =
>                               iomap_chain_bio(wpc->ioend->io_bio);
>               }
> -             bio_add_page(wpc->ioend->io_bio, page, len, poff);
> +             __bio_add_page(wpc->ioend->io_bio, page, len, poff);
>       }
>  
>       wpc->ioend->io_size += len;
> -- 
> 1.8.3.1
> 

Reply via email to