On Wed, 2020-11-25 at 15:37 +0800, Tiezhu Yang wrote: > devm_ioremap_resource() will be not built in lib/devres.c if > CONFIG_HAS_IOMEM is not set, of_address_to_resource() will be > not built in drivers/of/address.c if CONFIG_OF_ADDRESS is not > set, and then there exists two build errors about undefined > reference to "devm_ioremap_resource" and "of_address_to_resource" > in phy-mtk-xsphy.c under COMPILE_TEST and CONFIG_PHY_MTK_XSPHY, > make PHY_MTK_XSPHY depend on HAS_IOMEM and OF_ADDRESS to fix it. > > The above issue is reported by kernel test robot <l...@intel.com>, > through the discussion in the v1 patch, as Chunfeng said we need > also do this for config PHY_MTK_TPHY: > > drivers/phy/mediatek/phy-mtk-tphy.c:1157: retval = > of_address_to_resource(child_np, 0, &res); > drivers/phy/mediatek/phy-mtk-tphy.c:1123: tphy->sif_base = > devm_ioremap_resource(dev, sif_res); > drivers/phy/mediatek/phy-mtk-tphy.c:1164: instance->port_base = > devm_ioremap_resource(&phy->dev, &res); > > Reported-by: kernel test robot <l...@intel.com> > Signed-off-by: Tiezhu Yang <yangtie...@loongson.cn> > Acked-by: Randy Dunlap <rdun...@infradead.org> > --- The changes in v2 should be described after '---'
Except that, it looks good to me, Acked-by: Chunfeng Yun <chunfeng....@mediatek.com> Thanks a lot > drivers/phy/mediatek/Kconfig | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig > index 50c5e93..f44800b 100644 > --- a/drivers/phy/mediatek/Kconfig > +++ b/drivers/phy/mediatek/Kconfig > @@ -5,7 +5,8 @@ > config PHY_MTK_TPHY > tristate "MediaTek T-PHY Driver" > depends on ARCH_MEDIATEK || COMPILE_TEST > - depends on OF > + depends on OF && OF_ADDRESS > + depends on HAS_IOMEM > select GENERIC_PHY > help > Say 'Y' here to add support for MediaTek T-PHY driver, > @@ -29,7 +30,8 @@ config PHY_MTK_UFS > config PHY_MTK_XSPHY > tristate "MediaTek XS-PHY Driver" > depends on ARCH_MEDIATEK || COMPILE_TEST > - depends on OF > + depends on OF && OF_ADDRESS > + depends on HAS_IOMEM > select GENERIC_PHY > help > Enable this to support the SuperSpeedPlus XS-PHY transceiver for
