On Fri, 30 Nov 2007 15:54:01 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote:

> +int
> +i2c_write(unsigned char theSlave, void *data, size_t nbytes)
> +{
> +     int error, cntr = 3;
> +     unsigned char bytes_wrote = 0;
> +     unsigned char value;
> +     unsigned long flags;
> +
> +     spin_lock(&i2c_lock);
> +
> +     do {
> +             error = 0;
> +             /*
> +              * we don't like to be interrupted
> +              */
> +             local_irq_save(flags);
> +
> +             i2c_start();
> +             /*

Well if you _are_ interrupted prior to the local_irq_save() you'll deadlock
on i2c_lock?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to