On Tue, Nov 24, 2020 at 08:24:15PM -0800, Joe Perches wrote: > On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote: > > On 11/25/2020 11:51 AM, Joe Perches wrote: > > > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: > > > > When backport the upstream commit to the internal LTS kernel version, > > > > we usually use the following description [1] [2]: > > > > > > > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] > > > > or > > > > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. > > > Internal to what? > > > > > > If it's your own internal build system, I think you should > > > keep your own local patch to checkpatch. > > > > > > I don't see why the kernel version should accept it. > > > > > > Is this style used by anyone else? > > > > AFAIK, this style is only used in the stable tree, for example: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7 > > Greg?/Sasha? > > https://lore.kernel.org/lkml/995e0acb-c219-ea00-f078-7582516e2...@loongson.cn/T/#m2f3d87bd985bf3d4d7b63f1fa4f0490baa01119b > > Is this in your scripts?
My scripts put this into a patch when applying it to the stable tree, and so do Sasha's. I don't know why checkpatch would care about this as that's not used for this workflow at all. > Is this something you want/use? I wouldn't use it, and I doubt anyone else would. thanks, greg k-h