On Wed, Nov 18, 2020 at 4:17 AM Zhang Changzhong <zhangchangzh...@huawei.com> wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
> Reported-by: Hulk Robot <hul...@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzh...@huawei.com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7c21aaa8..092775e 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -12674,6 +12674,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const
> struct pci_device_id *ent)
> create_singlethread_workqueue("bnxt_pf_wq");
> if (!bnxt_pf_wq) {
> dev_err(&pdev->dev, "Unable to create
> workqueue.\n");
> + rc = -ENOMEM;
> goto init_err_pci_clean;
> }
> }
> --
Reviewed-by: Edwin Peer <edwin.p...@broadcom.com>
Regards,
Edwin Peer
smime.p7s
Description: S/MIME Cryptographic Signature
